Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add signed key constraints to SSH CA [continued] #6030

Merged
merged 5 commits into from
Feb 11, 2019
Merged

Add signed key constraints to SSH CA [continued] #6030

merged 5 commits into from
Feb 11, 2019

Conversation

catsby
Copy link
Contributor

@catsby catsby commented Jan 11, 2019 •
edited
Loading

Supersedes / continuation of #4468 , where I apply @vishalnayak 's feedback

  • renamed SignedKeyConstraints -> AllowedUserKeyLengths
  • changed the size limit to be size requirement, meaning >= -> ==
  • added additional test to verify new size constraints

@catsby catsby requested a review from vishalnayak January 11, 2019 20:04
@catsby
Refactoring to apply feedback
07c2178 
- changes names
- enforce exact match on key length
- add test
@catsby catsby force-pushed the ssh_keysize_checking branch from 3f0a926 to 07c2178 Compare January 11, 2019 20:06
@jefferai jefferai added this to the 1.0.3 milestone Jan 14, 2019
@hashicorp-cla
Copy link

hashicorp-cla commented Jan 15, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@catsby
Copy link
Contributor Author

catsby commented Jan 15, 2019

Hey @broamski , can you take a look here? I took your original PR #4468 and applied the feedback requested, let me know what you think 😄

Also, if you could please agree to the CLA as noted above, that would help move forward. Thanks!

@jefferai jefferai modified the milestones: 1.0.3, 1.0.4 Feb 1, 2019
@broamski
Copy link
Contributor

broamski commented Feb 6, 2019

@catsby This looks great - thanks for taking this on! 👍

@jefferai
Copy link
Member

jefferai commented Feb 7, 2019

Opportunistically retargeting for 1.0.3.

@jefferai jefferai modified the milestones: 1.0.4, 1.0.3 Feb 7, 2019
@catsby catsby mentioned this pull request Feb 7, 2019
Closed
@catsby
Copy link
Contributor Author

catsby commented Feb 7, 2019

Thanks @broamski !

briankassouf
briankassouf approved these changes Feb 11, 2019
View reviewed changes
Copy link
Contributor

@briankassouf briankassouf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jefferai jefferai merged commit 7c78575 into master Feb 11, 2019
@jefferai jefferai deleted the ssh_keysize_checking branch February 11, 2019 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jefferai jefferai jefferai left review comments

@briankassouf briankassouf briankassouf approved these changes

@vishalnayak vishalnayak Awaiting requested review from vishalnayak

@hashishaw hashishaw Awaiting requested review from hashishaw

Assignees

@hashishaw hashishaw

Labels
None yet
Projects
None yet
Milestone
1.0.3
Development

Successfully merging this pull request may close these issues.
6 participants
@catsby @hashicorp-cla @broamski @jefferai @briankassouf @hashishaw